Add async dataset runner for concurrent task execution#308
Open
MagellaX wants to merge 1 commit intohud-evals:mainfrom
Open
Add async dataset runner for concurrent task execution#308MagellaX wants to merge 1 commit intohud-evals:mainfrom
MagellaX wants to merge 1 commit intohud-evals:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 579b4f0df5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
MagellaX
force-pushed
the
feature/async-dataset-runner
branch
from
579b4f0 to
0438be6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
MagellaX
force-pushed
the
feature/async-dataset-runner
branch
from
e0e9463 to
f6ff476
Compare
Contributor
Author
|
any thoughts bro?? @lorenss-m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds run_dataset_async to fan out run_single_task calls with an asyncio concurrency cap.
Supports group_size runs per task and returns a flat list of Trace results.
Includes focused tests for the async runner’s behavior and grouping.
Note
Medium Risk
Introduces new concurrency and error-handling behavior around task execution; failures are now captured per-task and returned as error
Traces, so ordering/throughput and partial-failure semantics should be validated.Overview
Adds
run_dataset_asyncas a new public API to execute datasets by concurrently fanning outrun_single_taskcalls with anasynciosemaphore cap, optionalgroup_sizerepeats, and deterministic result ordering.Updates the datasets package exports to include
run_dataset_async, and adds tests covering empty input validation andgroup_sizerepetition/trace naming.Written by Cursor Bugbot for commit f6ff476. This will update automatically on new commits. Configure here.